Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 6.96%. Comparing base (4d9c7fc) to head (f4c34e1).
Report is 284 commits behind head on develop.

@@            Coverage Diff             @@
##           develop   #5533      +/-   ##
==========================================
- Coverage     9.54%   6.96%   -2.59%     
==========================================
  Files          325     400      +75     
  Lines        16411   21172    +4761     
==========================================
- Hits          1567    1474      -93     
- Misses       14844   19698    +4854     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

• @monsieurtanuki The sort order should be deterministic (ie order should not change all the time, possibly on date favorited ?)
• let's merge with one place, and add it in more places as requested by you and others ?

The sort order should be deterministic (ie order should not change all the time, possibly on date favorited ?)

I have no problems with ordering favorites by date. That's what I implemented before removing that part.
My concern is about non favorite stores: should we display them after favorite stores? That would mean a new store I've just selected wouldn't be at the start of my store list, but just after all the favorites. Not very user-friendly, especially if you have many favorite stores.

let's merge with one place, and add it in more places as requested by you and others ?

Makes sense.

My current code and current assumption:

1. latest selected stores first is user-friendly
2. explicit favorite icon is good enough for detecting favorites, especially in combination with bullet 1

We could make the favorite part collapsible @monsieurtanuki

We could make the favorite part collapsible

Too fancy for me, as a user and a coder. I'd let someone else code it.

I would suggest to do it step by step and get feedbacks from real life.
Now we can flag stores as favorites: what happens for users with many stores?

• is flagging some of them good enough?
• should we implement different lists of stores instead?
• should we rethink the UI altogether in order to make space for new features like GPS?

@teolemon I assume that you added prices in many many stores, and your opinion on the UX after testing the merged PR would be a good start for the next step.

Usually, you have several "big locations": Near my home, Near my parents, Holidays. But that suggests a more complex UI. I'm going to approve and we'll iterate @monsieurtanuki

Thank you @teolemon for your review!

Obviously many possible improvements.